Skip to content

Harden the net service: ordered saves, bounded logs and dialogs, no endpoint loops - #115

Merged
AlxcBTW merged 2 commits into
mainfrom
harden-net-service
Oct 27, 2026
Merged

AlxcBTW merged 2 commits into
mainfrom
harden-net-service

Conversation

@AlxcBTW

@AlxcBTW AlxcBTW commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Follow-up hardening from the robustness audit.

  • Sign-in saves go through one ordered writer and the temporary file is written under a lock, so a sign-out cannot be undone by an earlier save finishing late.
  • Observation logs: credential-bearing headers are replaced by a placeholder, each title's file stops growing at 16 MiB, and at most 8 invitation dialogs wait at once.
  • A session whose record of this device's endpoint keeps differing from what was pushed is pushed once per value instead of repeatedly.
  • An endpoint named by two different accounts (or by this device) gets no tunnel peer instead of silently overwriting the other.
  • A join that is answered after its game ended or was replaced leaves the session at once.

Each change has a regression test for the input that used to misbehave.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@AlxcBTW
AlxcBTW merged commit c52da96 into main Oct 27, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant