Repository navigation
Share play: stream delay, input delay and share_quality (T38) - #118
Merged
Merged
Conversation
… (T38) The host\x27s net service now moves the stream along the ladder from the guest\x27s reports: a new rate goes to the running encoder, a new size or frame rate is a new epoch, a new encoder and a config for the guest. The frame ring has the size of the top rung so that the picture can go up as well as down. The controller gets the player\x27s height limit for share_quality.
…y (T38) The guest's viewer works out how old each picture is from the host worker's stamp and the host clock's offset, which the guest's net service picks from the pings (smallest round trip of the last minute). The guest times its pad states against the host's pad_ack. Both figures (median and 95th percentile of 10 seconds) reach the launcher in the share event on both PCs. share_quality sets the player's maximum rate and picture height on the controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap 2 of T38. Stacked on #113 (the diff shrinks when that one is merged).
ClockPicker) and gives it to the viewer (ToWorker::Clock); the viewer works out each picture's age and reports median and 95th percentile of 10 s (DelayWindow).pad_ack(about 4 per second, with how long it held it); the guest takes half the round trip.stream_delay_ms/input_delay_ms(p50,p95) in the share event, on the guest's PC directly and on the host's PC through the guest'sreport.max_kbps,max_height): hub setting, applied to the running share's controller and to later ones.Tests: unit tests for the window, clock picker and frame age (incl. the 32-bit wrap), link and control round trips, command parsing, and two in-process integration tests (figures appear on both sides and are sane on one machine; the host's limit holds the picture at 540p).
Not proven: the figures between two real PCs on two networks (clock offset, asymmetric paths), the engine's copy time (not in the figure by design, see spec).
Need help on this PR? Tag
@codesmith-botwith what you need.