Repository navigation
Share worker: hardware H.264 on Linux (NVENC, VA-API) and clips on Linux - #99
Merged
Merged
Conversation
… on Linux Both backends are loaded from the system with dlopen, probed at start and fall back to OpenH264 (ADR 0036).
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task T47. Adds NVENC (libnvidia-encode.so.1 + libcuda.so.1, API 11.1) and VA-API (libva.so.2, libva-drm.so.2) behind the worker's encoder trait, loaded with dlopen (libloading, ISC), probed at start, falling back to OpenH264.
ANYPLAY_HWENC= auto/off/nvenc/vaapi. Hardware is announced as 1080p60hardwarecaps; clips on Linux use the same backends (hardware or nothing). No codec vendored; see ADR 0036 for licences.Tests: fake backends for selection and fallback, bit-exact H.264 header tests, size asserts on the FFI structs, and per-backend round trips that skip without a GPU (fail with
ANYPLAY_REQUIRE_HW).Not verified: real encoding on any GPU (no hardware in CI or on the build laptop). Launcher side (clips gated by cfg!(windows)) is not part of this PR.
Need help on this PR? Tag
@codesmith-botwith what you need.