Fix long param names overflowing Trigger DAG modal Body:#67859
Draft
shashbha14 wants to merge 2 commits into
Draft
Fix long param names overflowing Trigger DAG modal Body:#67859shashbha14 wants to merge 2 commits into
shashbha14 wants to merge 2 commits into
Conversation
|
Hi @shashbha14 , thank you for your work, might be worth taking a look at this related issue: #67852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67851
When a DAG param has a very long key name, the label was overflowing the Trigger DAG modal and breaking the layout.
The 'flexBasis: "30%"' was being set on the 'Field.Label' element instead of its 'Stack' parent, so it had no effect on the flex layout — the label column just grew to fit whatever content was inside it. Added 'minWidth: 0' to the 'Stack' so it can shrink properly, moved 'flexBasis' there, and added 'wordBreak="break-word"' on the label so long names wrap within the column instead of overflowing.
I used Claude (claude.ai) as an AI assistant for parts of this implementation.