Propogate verify and botocore_config in redshift cluster triggers#67876
Merged
kaxil merged 3 commits intoJun 2, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
kaxil
approved these changes
Jun 1, 2026
1 task
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 2, 2026
Incremental-update pass for commits that landed on main after this wave was prepared: - amazon: Propogate verify/botocore_config in redshift cluster triggers (apache#67876) → Features (mirrors the batch-triggers entry apache#67508). - databricks: Lock in workflow depends_on parent-key behavior (apache#66681) → Bug Fixes. - edge3: Fix Edge worker fork mode reporting supervisor failures as success (apache#67887) → Bug Fixes. - google: Migrate Stackdriver logging config to RemoteLogIO pattern (apache#66513) → Misc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five Redshift cluster triggers (
RedshiftCreateClusterTrigger,RedshiftPauseClusterTrigger,RedshiftCreateClusterSnapshotTrigger,RedshiftResumeClusterTrigger,RedshiftDeleteClusterTrigger)did not forward
verify,botocore_config, or evenregion_nameto the hook, so deferrableRedshift operators silently dropped custom SSL, botocore, and region settings when polling
AWS from the triggerer.
Follows the same pattern as the AWS Batch triggers migration (#67508) and the Lambda trigger
(
providers/amazon/src/airflow/providers/amazon/aws/triggers/lambda_function.py).What this changes:
**kwargspassthrough in all five trigger__init__methods so base-class params(
verify,botocore_config) reachAwsBaseWaiterTriggerregion_nameas an explicit parameter (previously not forwarded to the hook at all)hook()methods to passregion_name,verify, andbotocore_configto
RedshiftHookredshift_cluster.pyto forward these paramsRedshiftClusterTriggeris intentionally out of scope — it uses a custom polling loop withBaseTriggerdirectly and a dynamictarget_statusrather than a single waiter, so migratingit would require introducing custom waiters per state (noted by @dominikhei on #35278).
Part of #35278
Was generative AI tooling used to co-author this PR?