Skip to content

feat: support filtering the key and value of labels #13398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okaybase wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: support filtering the key and value of labels #13398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ca85f
support filtering the key and value of label
okaybase May 20, 2026
ab1fc55
add test case for matching labels' key and value
okaybase May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apisix/admin/v3_adapter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@ local function filter(body, args, resource)
if args.label then
label_matched = false
if body.list[i].value.labels then
for k, _ in pairs(body.list[i].value.labels) do
if k == args.label then
for k, v in pairs(body.list[i].value.labels) do
if k == args.label or k .. ":" .. v == args.label then
label_matched = true
break
end
Expand Down
8 changes: 8 additions & 0 deletions t/admin/filter.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,14 @@ passed
res = json.decode(res)
assert(#res.list == 0)

-- match labels' key and value
code, body, res = t('/apisix/admin/routes/?label=env2:production',
ngx.HTTP_GET
)
res = json.decode(res)
assert(#res.list == 1)
assert(res.list[1].value.id == "2")

ngx.status = code
ngx.say(body)
}
Expand Down
Loading