Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation follows Iceberg’s constant-materialization semantics and includes broad integration coverage.
0 open findings
What changed in this PR
Adds native Iceberg COW scan support for _partition metadata.
Changes:
- Materializes unified partition metadata via Iceberg task constants.
- Preserves partition field IDs and serializes Catalyst struct literals.
- Adds Parquet/ORC integration and fallback coverage.
| File | Description |
|---|---|
AuronIcebergIntegrationSuite.scala |
Tests partition metadata and fallback scenarios. |
NativeIcebergTableScanExec.scala |
Serializes existing Catalyst partition values. |
IcebergScanSupport.scala |
Materializes _partition task constants. |
AuronIcebergSourceUtil.scala |
Builds projected unified partition types with Iceberg IDs. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2558
Rationale for this change
Queries projecting
_partitioncurrently fall back to Spark even when the Iceberg COW scan is otherwise eligible for native execution.What changes are included in this PR?
_partitionthrough the existing per-task constant path using Iceberg's unified partition type andPartitionUtil.constantsMap.The scope covers regular COW scans.
_pos, delete-file handling, and_partitionin changelog scans remain outside this change.Are there any user-facing changes?
Eligible COW queries projecting
_partitionor its fields can useNativeIcebergTableScan. No new configuration is required.How was this patch tested?
./dev/reformat --check../build/mvn -B -ntp -Ppre,spark-3.5,scala-2.12,iceberg-1.10.1 -pl thirdparty/auron-iceberg -am -DskipTests clean install../build/mvn -B -ntp -Ppre,spark-3.5,scala-2.12,iceberg-1.10.1 -pl thirdparty/auron-iceberg -DskipBuildNative -Dsuites=org.apache.auron.iceberg.AuronIcebergIntegrationSuite test.Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
ASF guidance: https://www.apache.org/legal/generative-tooling.html