Repository navigation
Conversation
slfan1989
requested changes
Oct 25, 2026
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
The timing scopes and separate sort metrics look correct. As a follow-up, a regression test with non-empty join keys would help verify sort timing and spill metric propagation.
Contributor
Author
|
Thanks for the suggestion. @slfan1989 Added a regression test covering non-empty join keys, sort timing, and spill metric propagation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2603
Rationale for this change
Output backpressure can cause timing metrics to underflow when a native broadcast join falls back to sort-merge join. Negative values are ignored when reported to Spark, leaving the fallback time at zero even though the fallback executed.
This surfaced in PR #2599's CI: query result comparisons passed, but
AuronBroadcastNestedLoopJoinSuitefailed its positive fallback-time assertion. The affected timing code is already present in master.What changes are included in this PR?
Are there any user-facing changes?
Corrects timing metrics reported to Spark for native SMJ fallback. Query results and public APIs are unchanged.
How was this patch tested?
sorted_fallback_metrics_exclude_output_wait, which delays output consumption, checks results for both build sides, and verifies positive fallback and compute timing metrics.Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: OpenAI Codex (GPT-6)ASF guidance: https://www.apache.org/legal/generative-tooling.html