Repository navigation
Conversation
… Parquet columns Signed-off-by: Ma Zhengxuan <1319614897@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2595.
Rationale for this change
Native Parquet Bloom filter pruning probes Decimal128 literals using all 16 bytes of the unscaled value. For FIXED_LEN_BYTE_ARRAY columns with a smaller declared width, these bytes differ from those hashed by the writer. This can incorrectly discard row groups containing matching values.
What changes are included in this PR?
Are there any user-facing changes?
This fixes native decimal Bloom filter pruning when a decimal predicate reaches that path. There are no API or configuration changes.
Existing decimal planner guards and the default Bloom filter setting remain unchanged. Enabling decimal pruning for Iceberg is outside this PR.
How was this patch tested?
Ran locally:
cargo test --locked -p datafusion-ext-plans cargo clippy --locked -p datafusion-ext-plans --test parquet_bloom_pruning -- -D warnings cargo fmt --all -- --check ./dev/reformat --checkThe formatting script was run with JDK 8 and JDK 17 configured.
Results:
Spark SQL end-to-end tests and remote CI have not been run.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
ASF guidance: https://www.apache.org/legal/generative-tooling.html