[OpenTelemetry] Add gcp otel auth extension#38773
Conversation
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new extension module for Apache Beam that enables GCP authentication for OpenTelemetry OTLP exporters. By leveraging Google Application Default Credentials (ADC), this extension automatically configures exporters to include the necessary authorization headers when communicating with GCP telemetry endpoints, facilitating seamless integration with Google Cloud monitoring and tracing services. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new extension module, opentelemetry-gcp-auth-extension, to provide GCP authentication support for OpenTelemetry OTLP exporters in Apache Beam. The review feedback highlights several critical improvements: lazily retrieving Google Application Default Credentials (ADC) to prevent application startup crashes when ADC is not configured and GCP is not targeted; avoiding resource leaks by ensuring the original exporters are shut down when new ones are built; preventing potential NullPointerExceptions during header flattening; and refining endpoint checks to avoid noisy warnings when non-GCP endpoints are used.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
17050ef to
dc69a2a
Compare
8c6b2a1 to
8a86e09
Compare
8a86e09 to
bc2ff62
Compare
|
Are there classes that can be |
Forks https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/gcp-auth-extension/src/main/java/io/opentelemetry/
Why it is needed - gcp-auth-extension in otel adds auth to all exporters, once fixed, we will be able to remove this module.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.