[Veeam] Fix for dirty context not being returned on el9#13613
Merged
Conversation
nvazquez
requested review from
abh1sar,
kiranchavala,
shwstppr and
weizhouapache
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13613 +/- ##
============================================
+ Coverage 19.50% 19.64% +0.14%
- Complexity 19444 19786 +342
============================================
Files 6303 6368 +65
Lines 569286 575047 +5761
Branches 69791 70365 +574
============================================
+ Hits 111040 112973 +1933
- Misses 446093 449787 +3694
- Partials 12153 12287 +134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
abh1sar
approved these changes
Jul 14, 2026
Contributor
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18566 |
Member
… flag) tuples instead of a flat list returned by the block_status api supported by older libnbd versions. The dirty extents were not ready correctly for the block_status_64 return and as a result image server always reported the whole image range as dirty. This commit fixes by normalizing the value returned by both block_status and block_status_64. It also adds warning whenever there is an issue getting the dirty extents and the code falls back to returning the full range as dirty.
weizhouapache
force-pushed
the
423-veeam-fix-dirty-context
branch
from
bfa3f56 to
72d8b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ibbnd > 1.19 supports block_status_64 command which returns (length, flag) tuples instead of a flat list returned by the block_status api supported by older libnbd versions.
The dirty extents were not ready correctly for the block_status_64 return and as a result image server always reported the whole image range as dirty.
This PR fixes by normalizing the value returned by both block_status and block_status_64. It also adds warning whenever there is an issue getting the dirty extents and the code falls back to returning the full range as dirty.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?