UI: fix cannot update physical network - #13810
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the UI action configuration for Physical Networks to fix the “Update Physical Network” dialog rendering issue described in #13804, aligning the UI’s editable fields with the actual updatePhysicalNetwork API parameters.
Changes:
- Removes the unsupported
externaldetailsargument from the Physical Network “update” action to prevent the autogenerated form from including an invalid/undefined field. - Keeps the update dialog focused on supported editable fields (
vlan,tags).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13810 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19790 -2
============================================
Files 6368 6368
Lines 574881 574881
Branches 70351 70351
============================================
- Hits 112970 112963 -7
- Misses 449639 449647 +8
+ Partials 12272 12271 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Description
This PR fixes #13804
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?