Skip to content

Android: add try catch around dialog.dismiss() to prevent crashes#1018

Open
jgruenberger wants to merge 1 commit into
apache:masterfrom
jgruenberger:master
Open

Android: add try catch around dialog.dismiss() to prevent crashes#1018
jgruenberger wants to merge 1 commit into
apache:masterfrom
jgruenberger:master

Conversation

@jgruenberger

@jgruenberger jgruenberger commented Sep 5, 2023

Copy link
Copy Markdown

Platforms affected

many different Android platforms out in the field

Motivation and Context

Resolves #470
Resolves #893
Resolves #1007
Resolves #384

Description

just adds a try catch block

Testing

We tested the change out in the field in a productive environment on 100+ different Android devices

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@jgruenberger

jgruenberger commented Sep 5, 2023

Copy link
Copy Markdown
Author

We are getting app crashes from InAppBrowser on Crashlytics. This try catch claused resolved the issue.

Resolves #470
Resolves #893
Resolves #1007
Resolves #384

@platov

platov commented Apr 8, 2024

Copy link
Copy Markdown

@jgruenberger , will this PR be merged?

@jgruenberger

Copy link
Copy Markdown
Author

Hi @platov,

i created the PR and hope the owner of the repo will merge it....

Best,
Juergen

@aliyafthh

Copy link
Copy Markdown

Hi, can i know when this PR will be merged?

Makiwin added a commit to Makiwin/cordova-plugin-inappbrowser that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants