DFDL-1555: insteading of erroring yet, change to warning#1738
Open
naga-panchumarty wants to merge 1 commit into
Open
DFDL-1555: insteading of erroring yet, change to warning#1738naga-panchumarty wants to merge 1 commit into
naga-panchumarty wants to merge 1 commit into
Conversation
Formatting fixed
naga-panchumarty
force-pushed
the
DFDL-1555
branch
from
ba5fe65 to
bae2793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1555
Description
when a variable defined in launch.json does not exist in the DFDL schema, the debugger previously threw an unhandled ExternalVariableException and aborted the session entirely. This change catches that exception and changes it to a warning, allowing the debugger to start normally with the unrecognized variable simply skipped.
Wiki
Confirmation Testing
Manually tested by adding "variables": { "foo": "bar" } to a launch.json where foo does not exist in the target schema. Confirmed the debugger launches successfully and the warning message appears. Confirmed that valid variables (ones that do exist in the schema) are still applied correctly.