chore: remove dead indexed_field.rs - #1746
Merged
Merged
Conversation
The `pub mod indexed_field;` declaration and the PyGetIndexedField class registration were dropped from crates/core/src/expr.rs in b5446ef (#728) when DataFusion 39 replaced Expr::GetIndexField with the FieldAccessor trait, but the file stayed on disk. It has not been compiled since, and it imports GetIndexedField, which no longer exists upstream. The nightly pre-commit rust-fmt hook formats files by path, so it keeps rewriting the orphan; stable `cargo fmt --check` in CI walks the module tree and never sees it. Deleting the file ends that churn. Closes #1745 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1745.
Rationale for this change
crates/core/src/expr/indexed_field.rshas not been part of the crate since b5446ef (#728, the DataFusion 39 upgrade), which removed bothpub mod indexed_field;and them.add_class::<indexed_field::PyGetIndexedField>()registration fromcrates/core/src/expr.rsafter upstream replacedExpr::GetIndexFieldwith theFieldAccessortrait. The file was left on disk.What changes are included in this PR?
Deletes
crates/core/src/expr/indexed_field.rs. Nothing else changes.Are there any user-facing changes?
None