Skip to content

[FIX] Prevent Hessian2 serializable security bypass via writeReplace (#16287) #16288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LI123456mo wants to merge 1 commit into from
+13 −0
Closed

[FIX] Prevent Hessian2 serializable security bypass via writeReplace (#16287) #16288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2SerializerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.io.Serializable;

import com.alibaba.com.caucho.hessian.io.Deserializer;
import com.alibaba.com.caucho.hessian.io.HessianProtocolException;
import com.alibaba.com.caucho.hessian.io.InputStreamDeserializer;
import com.alibaba.com.caucho.hessian.io.JavaDeserializer;
import com.alibaba.com.caucho.hessian.io.JavaSerializer;
Expand Down Expand Up @@ -65,6 +66,18 @@ protected Serializer getDefaultSerializer(Class cl) {
} else return JavaSerializer.create(cl);
}

@Override
public Serializer getSerializer(Class cl) throws HessianProtocolException {
try {
// 1. Force the security guard pre-check to run first
defaultSerializeClassChecker.loadClass(getClassLoader(), cl.getName());
} catch (ClassNotFoundException e) {
// ignore
}
checkSerializable(cl);
return super.getSerializer(cl);
}

@Override
protected Deserializer getDefaultDeserializer(Class cl) {
if (InputStream.class.equals(cl)) {
Expand Down
Loading