[server] Ensure KV tablet dir is removed before log and surface clean…#3484
Open
gyang94 wants to merge 1 commit into
Open
[server] Ensure KV tablet dir is removed before log and surface clean…#3484gyang94 wants to merge 1 commit into
gyang94 wants to merge 1 commit into
Conversation
gyang94
force-pushed
the
remove-kv-orphan
branch
from
8249b67 to
2a4dcfc
Compare
…up failures When cleaning residual data for a dropped table/partition during startup, delete the KV tablet directory before dropping the log, and only drop the log once the KV directory is confirmed gone. KV deletion failures are now logged (warn) instead of being silently swallowed, keeping the log as an anchor so the cleanup can be retried. Also propagate KV deletion failures in ReplicaManager.sweepOrphanTabletDirs so the log is not dropped when orphan KV cleanup fails.
gyang94
force-pushed
the
remove-kv-orphan
branch
from
2a4dcfc to
537d90f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cleaning residual data for a dropped table/partition during startup, delete the KV tablet directory before dropping the log, and only drop the log once the KV directory is confirmed gone. KV deletion failures are now logged (warn) instead of being silently swallowed, keeping the log as an anchor so the cleanup can be retried.
Also propagate KV deletion failures in ReplicaManager.sweepOrphanTabletDirs so the log is not dropped when orphan KV cleanup fails.
Purpose
Linked issue: close #xxx
Brief change log
delete kv tablet dir first, if success, then delete the log dir.
Tests
API and Format
Documentation