Register CriteriaTypeCheckingExtension and cover createCriteria().<terminal>{} closures

[codeconsole]

What

CriteriaTypeCheckingExtension exists in grails-core but is not registered in @GrailsCompileStatic's extension list, and isCriteriaCall only recognizes the Domain.withCriteria { … } / Domain.createCriteria() forms (closure as the direct argument). The chained Domain.createCriteria().<terminal> { … } form — where the closure is the argument to a terminal called on the builder — is never matched, so a criteria scope is never opened for it.

Why it matters

Most chained terminals (list, listDistinct, get, scroll) still type-check today because BuildableCriteria declares them with a Closure parameter and @DelegatesTo resolves the closure body. But count(Closure) is not declared on BuildableCriteria, so:

@GrailsCompileStatic
class Foo {
    def c() { Person.createCriteria().count { eq 'name', 'Anakin' } }
}

fails static compilation on stock 8.0.x:

[Static type checking] - Cannot find matching method
org.grails.datastore.mapping.query.api.BuildableCriteria#count(groovy.lang.Closure)

forcing a @CompileDynamic escape hatch.

Change

1. Extend isCriteriaCall to also open a criteria scope when the call is a terminal (list, listDistinct, get, count, scroll) chained directly on Domain.createCriteria(). Registration alone is not enough — the createCriteria() scope is exited (via afterMethodCall) before the terminal call is visited, so the terminal needs to be recognized in its own right.
2. Add org.grails.compiler.CriteriaTypeCheckingExtension to the @CompileStatic(extensions=[…]) list on @GrailsCompileStatic.

Test

Adds 'Test compiling a class which invokes a chained createCriteria() terminal on a domain class' to GrailsCompileStaticCompilationErrorsSpec, covering all six chained terminals. It fails on stock 8.0.x (on the count terminal) and passes with this change. The existing GRAILS-11255 criteria spec continues to pass.

Scope / limits

The extension makes the direct children of the criteria closure dynamic. Deeply nested builder closures (e.g. projections { property '…' }) and post-processing that indexes the result (withCriteria { … }[0]) still require @CompileDynamic — out of scope here.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.2620%. Comparing base (41f9fb9) to head (c1410a5).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                8.0.x     #15720         +/-   ##
===================================================
- Coverage     48.3483%   18.2620%   -30.0864%     
+ Complexity      15104        258      -14846     
===================================================
  Files            1870         54       -1816     
  Lines           85459       3176      -82283     
  Branches        14901        527      -14374     
===================================================
- Hits            41318        580      -40738     
+ Misses          37805       2486      -35319     
+ Partials         6336        110       -6226     

see 1816 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: c1410a5
▶️ Tests: 10442 executed
⚪️ Checks: 43/43 completed

---

Learn more about TestLens at testlens.app.