[#10865] improvement(helm): Add priorityClassName support to Gravitino Helm charts#11698
Open
dennismdejong wants to merge 2 commits into
Open
[#10865] improvement(helm): Add priorityClassName support to Gravitino Helm charts#11698dennismdejong wants to merge 2 commits into
dennismdejong wants to merge 2 commits into
Conversation
…nfigurable via postgresql.existingSecretName
…avitino Helm charts
danhuawang
reviewed
Jun 17, 2026
danhuawang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! The priorityClassName feature looks good overall. A couple of comments:
1. Please split this PR — it contains two unrelated changes.
Commit 97566fd (making the init-postgresql secret name configurable, #11696) is unrelated to the priorityClassName feature (#10865). Please remove it from this PR and submit it separately. Mixing unrelated changes makes review and bisect harder.
2. (Nit) Missing blank line in lance-rest-server deployment.yaml
The priorityClassName block is added directly after the tolerations {{- end }} without a separating blank line, inconsistent with the other two charts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
priorityClassNamesupport to all three Gravitino Helm charts (gravitino, gravitino-iceberg-rest-server, gravitino-lance-rest-server).Why are the changes needed?
The Helm charts do not expose
priorityClassNameon the pod spec. On shared clusters where batch jobs compete with production services, Kubernetes uses PriorityClass to decide which pods to evict. Without this, Gravitino pods have no priority tier and can be evicted by lower-priority workloads during resource pressure, causing unexpected downtime for production catalog services.Fix: #10865
Does this PR introduce any user-facing change?
Yes — adds a new
priorityClassNamevalue to all three charts:dev/charts/gravitino/values.yamldev/charts/gravitino-iceberg-rest-server/values.yamldev/charts/gravitino-lance-rest-server/values.yamlDefault is empty string (
""), which omits the field — fully backward compatible.How was this patch tested?
helm linton all 3 charts — passedhelm template— verifiedpriorityClassNamerenders when set, omitted when emptyhelm unittest— added test cases for all 3 charts (set + omitted scenarios):