Conversation
yuqi1129
force-pushed
the
me/fix-role-relation-cache-grant-11701
branch
from
dc95bf1 to
48e8885
Compare
yuqi1129
force-pushed
the
me/fix-role-relation-cache-grant-11701
branch
from
48e8885 to
02fe77a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Invalidate derived relation cache entries after entity writes for role-related relationships stored inside entity fields:
METADATA_OBJECT_ROLE_RELcaches.ROLE_USER_RELcaches.ROLE_GROUP_RELcaches.Why are the changes needed?
When a new relation is added through an entity update, the reverse index may not contain a path from the updated entity to an already cached relation list on the other side. A later load/list can then return stale data until the relation cache entry expires.
Fix: #11701
Does this PR introduce any user-facing change?
No.
How was this patch tested?
./gradlew :core:spotlessApplygit diff --check./gradlew :core:test --tests org.apache.gravitino.storage.TestEntityStorageRelationCache.testGrantPrivilegeInvalidatesMetadataObjectRoleRelCache --tests org.apache.gravitino.storage.TestEntityStorageRelationCache.testCreateRoleInvalidatesMetadataObjectRoleRelCache --tests org.apache.gravitino.storage.TestEntityStorageRelationCache.testGrantRoleToUserInvalidatesRoleUserRelCache --tests org.apache.gravitino.storage.TestEntityStorageRelationCache.testGrantRoleToGroupInvalidatesRoleGroupRelCache --tests org.apache.gravitino.storage.TestEntityStorageRelationCache.testCacheInvalidationOnNewRelationReverse -PskipITs -PskipDockerTests=false