Support custom registry ip and port for Nacos registration#8026
Support custom registry ip and port for Nacos registration#8026somiljain2006 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8026 +/- ##
============================================
+ Coverage 72.23% 72.30% +0.07%
Complexity 876 876
============================================
Files 1310 1310
Lines 49975 50002 +27
Branches 5945 5951 +6
============================================
+ Hits 36099 36154 +55
+ Misses 10924 10896 -28
Partials 2952 2952
🚀 New features to boost your workflow:
|
|
@funky-eyes Can you review this pr? |
1ac2973 to
3927e70
Compare
|
I reproduced the CI failures locally using the same full test command. The failing tests are: org.apache.seata.config.nacos.NacosMockTest The failures occur in seata-config-nacos, while my change only affects seata-discovery-nacos. I also verified that isolated module tests pass locally: ./mvnw -pl config/seata-config-nacos -DskipITs test The NacosMockTest failure appears to be timing/startup related: com.alibaba.nacos.api.exception.NacosException: So this currently looks like an unrelated flaky/full-suite integration issue rather than a regression introduced by the registry IP/port customization change. |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Fixes #8016
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Run unit tests:
./mvnw -pl discovery/seata-discovery-nacos -Dtest=NacosRegistryServiceImplTest test
Start the Nacos server locally
Run Seata server from source with JVM overrides:
./mvnw -pl server clean compile exec:java
-Dexec.mainClass="org.apache.seata.server.ServerApplication"
-Dregistry.nacos.ip=127.0.0.1
-Dregistry.nacos.port=21908
Verify registration in Nacos:
curl http://localhost:8848/nacos/v1/ns/instance/list?serviceName=seata-server
Expected result:
This confirms that System properties override the default registration address.
Ⅴ. Special notes for reviews
N/A