optimize: limit allowlist cache growth#8120
Open
LegendPei wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #8120 +/- ##
============================================
+ Coverage 72.80% 73.01% +0.21%
Complexity 883 883
============================================
Files 1327 1327
Lines 50719 50734 +15
Branches 6049 6052 +3
============================================
+ Hits 36924 37043 +119
+ Misses 10802 10691 -111
- Partials 2993 3000 +7
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Limit the growth of the JSON deserialization allowlist cache.
This PR updates
JsonAllowlistManagerto:It also adds unit tests covering rejected class names, overlong class names, cache hits, and cache size limits.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Added unit tests in
JsonAllowlistManagerTest.Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews