KAFKA-20645: Move LogLoaderTest to storage module#22426
Open
mimaison wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
core
majialoong
reviewed
Jun 1, 2026
| LogManager logManager = interceptedLogManager(logConfig, logDirs, logDirFailureChannel, time, | ||
| cleanShutdownInterceptedValue, simulateError); | ||
| logManager.getOrCreateLog(topicPartition, true, false, Optional.empty()); | ||
| assertFalse(logDirFailureChannel.hasOfflineLogDir(logDir.getAbsolutePath()), "log dir should not be offline before load logs"); |
Contributor
There was a problem hiding this comment.
Thanks for the patch!
It looks like this is now using the class-level logDir, whereas the Scala version used the logDir created inside testLogRecoveryIsCalledUponBrokerCrash.
This means the assertion may check a different directory after the migration. Should this use the local logDir instead?
Member
Author
There was a problem hiding this comment.
Nice find! This is indeed a mistake, I pushed a fix. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also delete LogTestUtils.scala as it's not used anymore
Reviewers: Ken Huang s7133700@gmail.com