fix(bitmap): align BITFIELD bit order with Redis#3565
Open
maoyouaa wants to merge 1 commit into
Open
Conversation
PragmaTwice
reviewed
Jul 23, 2026
PragmaTwice
left a comment
Member
There was a problem hiding this comment.
Please check our Guidelines for AI-assisted Contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BITFIELDandBITFIELD_ROon bitmap keys with Redis bit ordering by reversing bits at the bitmap storage boundary.Root cause
Kvrocks bitmap segments store bits in LSB order, while
BITFIELDinterprets byte buffers in MSB order. The bitmap conversion path copied bytes directly, producing results inconsistent with Redis and withGET/GETBIT.Compatibility
Bitmap values written by older versions through the incorrect
BITFIELDpath have no format marker and cannot be distinguished automatically. This change preserves the existing bitmap LSB storage format and fixes conversion at theBITFIELDboundary.Validation
TestBitmapgit diff --checkCloses #2500