refactor(desktop): register Goals and WorkHub controller owners - #5214
Open
chihumyum wants to merge 1 commit into
Open
refactor(desktop): register Goals and WorkHub controller owners#5214chihumyum wants to merge 1 commit into
chihumyum wants to merge 1 commit into
Conversation
Register the existing feature-owned controller call sites and mount WorkHubRoot through the public feature entry in composition. Preserve surface selection, locale updates, and provider lifecycle with focused tests. Refs apache#4582 Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goals and WorkHub already call their controllers below AppShell, but neither call site is registered in
controllerOwners. RegisteruseGoalControllerwithGoalProvideranduseWorkHubControllerwithWorkHubRoot, each with one production call, so the existing architecture gate rejects additional callers, public controller exports, and removal of the ownership contract.WorkHub's surface switch currently imports
WorkHubRootprivately, which the owner contract rejects. Composition now supplies<WorkHubRoot />through the public feature entry as the switch's WorkHub slot. Surface selection and the existing locale/Toast providers, appearance subscription, and ready notification retain their mount boundaries. The checker implementation and debt measurements are unchanged.Refs #4582
Verification
npm ciwith Node 24.19.0 and npm 11.19.0; build, typecheck, lint, format, and Desktop/UI Knip passed.upstream/mainpassed; AppShell hook gate remains 40 hooks / 65 call sites.git diff --checkpassed.main96f8e3f93; the upstream change touches only Runtime session trace projection. Its rebuilt tests, the focused Goals/WorkHub tests, and the architecture base check passed after rebase;range-diffis unchanged andmerge-treeis clean.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the registrations and composition adjustment, wrote tests, ran validation, and performed automated self-review. The commit carries a
Generated-by: Codextrailer. Automated review is not independent human approval.Checklist
Does this PR entail a change in behavior?