feat(desktop): surface parent task status in Side Conversations - #5232
feat(desktop): surface parent task status in Side Conversations#5232hbw00111 wants to merge 3 commits into
Conversation
Project canonical pending interaction kinds and root execution into the companion panel, with settled-turn history fallback and lifecycle guards. Reuse the parent conversation controls and cover navigation, reconnect, and browser focus behavior. Refs apache#5230 Generated-by: Grok Build (grok-4.6, xhigh) Generated-by: OpenAI Codex
Generated-by: OpenAI Codex
Reuse the continuity fixture with idle session state and the matching host epoch so parent execution observation receives canonical interaction data. Generated-by: Grok Build (grok-4.6, xhigh)
|
The latest upstream CI run failed in I reran the unchanged PR head ( There is a plausible sampling race: the test disables displacement recording during wheel input and reenables it after the final animation frames. A range change completed in that interval is discarded. A controlled exercise of the existing probe reproduces zero recorded boundaries in that ordering. This supports a timing-sensitive test failure, though it does not prove the exact frame ordering in the failed CI run. Could a maintainer rerun the failed upstream job at https://github.com/apache/maka/actions/runs/34697088741 ? GitHub rejected my rerun request because it requires repository admin rights. No assertions, retries, or code were changed for this rerun. |
Summary
Side Conversations now show when the parent task needs input or approval, is running, or most recently completed, failed, or was interrupted. The notice uses canonical Host execution and pending interaction kinds, with settled Turn records for sessions opened after a run ends. An idle session is not reported as completed.
All side panels share one parent observation. Navigation and reconnect invalidate stale reads, including lifecycle notifications delivered in one React batch. The action focuses the existing parent interaction or composer; responses still use the existing handlers.
Fixes #5230. Refs #4331 (parent-status item only).
Verification
npm run lint,npm run format:check,npm run build,npm run typecheck,npx knip --workspace apps/desktop,npx knip --workspace packages/ui, and the renderer architecture check.SandboxBoundaryPrompt; its play function verifies that the action focuses an existing parent approval control.Storybook, 1280×900, light/default. Before is the existing SideChat story from unmodified base
83aa12a29; after adds the parent sandbox approval scenario in the same Workbar frame. These are component scenarios, not live Electron screenshots.AI use
Tool(s) and scope: Grok Build (
grok-4.6,xhigh) implemented the feature, regression tests and Storybook scenario. OpenAI Codex reviewed the changes, independently reproduced a reconnect bug, verified the fixes and prepared this PR on behalf of @hbw00111. The commit includes bothGenerated-bytrailers.Checklist
Does this PR entail a change in behavior?