Skip to content

Restore reportNameSuffix in testcase classname attribute (regression since 3.5.4) #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UtkarshSinghChauhan wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Restore reportNameSuffix in testcase classname attribute (regression since 3.5.4) #3265

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a15809
Restore reportNameSuffix in testcase classname XML report (regression…
UtkarshSinghChauhan Feb 17, 2026
bed1a6c
Fix missing testcase entries in rerun logic
UtkarshSinghChauhan Mar 27, 2026
e43d0fe
Fix missing testcase entries in rerun logic and added test to ensure …
UtkarshSinghChauhan Mar 27, 2026
42a7ec8
Resolved merge conflict with master
UtkarshSinghChauhan Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...re-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,8 @@ private void startTestElement(XMLWriter ppw, WrappedReportEntry report) throws I

String className = phrasedClassName
? report.getReportSourceName(reportNameSuffix)
: report.getSourceText() != null ? report.getSourceText() : report.getSourceName(reportNameSuffix);
: report.getSourceName(reportNameSuffix);

@slawekjaranowski slawekjaranowski Feb 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was changed in

@UtkarshSinghChauhan UtkarshSinghChauhan Mar 27, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out.

My change does not reintroduce the issue from SUREFIRE-2298.
The goal of this change is to restore reportNameSuffix in the
testcase classname attribute, which was lost after that change.

Using report.getSourceName(reportNameSuffix) still keeps the
correct behavior for JUnit 5 nested classes while restoring
the suffix in the XML report classname.

I will also add an integration test to verify this behavior.
Sorry for the late reply.


if (className != null) {
ppw.addAttribute("classname", extraEscapeAttribute(className));
}
Expand Down
Loading