Pin maven-jar-plugin 3.5.1 in modular IT fixtures - #3409
Open
slawekjaranowski wants to merge 1 commit into
Open
Conversation
The windows-latest jdk-11 CI cell fails for every PR since Maven 3.10.0-rc-1 became the IT baseline: its super-POM pins maven-jar-plugin 3.5.0, whose plexus-archiver 4.10.4 throws an NPE (JarToolModularJarArchiver.fixLastModifiedTimeZipEntries) when packaging modular JARs on Windows with JDK < 14 (no 'jar --date'; POSIX attribute view is null on Windows). Details and validation: apache/maven-jar-plugin#555 maven-jar-plugin 3.5.1 (released 2026-07-22) ships plexus-archiver 4.12.0 with the fix. Pin 3.5.1 explicitly in the four affected modular fixtures so they stop depending on the super-POM's jar-plugin version. Verified locally under Maven 3.10.0-rc-1: Surefire1733JUnit4IT, Surefire1733TestngIT, Surefire2190JUnit4IT and Surefire1993JpmsProvidingModulesIT green; fixture logs confirm maven-jar-plugin:3.5.1:jar executed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 6e80c75)
ascheman
approved these changes
Jul 27, 2026
ascheman
left a comment
Contributor
There was a problem hiding this comment.
Same approach as the merged #3398 pin, extended to the modular-JAR IT fixtures that carry their own POMs (so they didn't inherit the pin). Correct fix for the plexus-archiver 4.10.4 NPE (jar#555) on Windows JDK<14. LGTM — thanks @slawekjaranowski. (Approving on the logic; the windows-latest jdk-11 cell is the one to watch as CI finishes.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows-latest jdk-11 CI cell fails for every PR since Maven 3.10.0-rc-1 became the IT baseline: its super-POM pins maven-jar-plugin 3.5.0, whose plexus-archiver 4.10.4 throws an NPE
(JarToolModularJarArchiver.fixLastModifiedTimeZipEntries) when packaging modular JARs on Windows with JDK < 14 (no 'jar --date'; POSIX attribute view is null on Windows). Details and validation: apache/maven-jar-plugin#555
maven-jar-plugin 3.5.1 (released 2026-07-22) ships plexus-archiver 4.12.0 with the fix. Pin 3.5.1 explicitly in the four affected modular fixtures so they stop depending on the super-POM's jar-plugin version.
Verified locally under Maven 3.10.0-rc-1: Surefire1733JUnit4IT, Surefire1733TestngIT, Surefire2190JUnit4IT and
Surefire1993JpmsProvidingModulesIT green; fixture logs confirm maven-jar-plugin:3.5.1:jar executed.
(cherry picked from commit 6e80c75)
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.