Skip to content

Pin maven-jar-plugin 3.5.1 in modular IT fixtures - #3409

Open
slawekjaranowski wants to merge 1 commit into
apache:surefire-3.5.xfrom
slawekjaranowski:cp-3398
Open

Pin maven-jar-plugin 3.5.1 in modular IT fixtures#3409
slawekjaranowski wants to merge 1 commit into
apache:surefire-3.5.xfrom
slawekjaranowski:cp-3398

Conversation

@slawekjaranowski

Copy link
Copy Markdown
Member

The windows-latest jdk-11 CI cell fails for every PR since Maven 3.10.0-rc-1 became the IT baseline: its super-POM pins maven-jar-plugin 3.5.0, whose plexus-archiver 4.10.4 throws an NPE
(JarToolModularJarArchiver.fixLastModifiedTimeZipEntries) when packaging modular JARs on Windows with JDK < 14 (no 'jar --date'; POSIX attribute view is null on Windows). Details and validation: apache/maven-jar-plugin#555

maven-jar-plugin 3.5.1 (released 2026-07-22) ships plexus-archiver 4.12.0 with the fix. Pin 3.5.1 explicitly in the four affected modular fixtures so they stop depending on the super-POM's jar-plugin version.

Verified locally under Maven 3.10.0-rc-1: Surefire1733JUnit4IT, Surefire1733TestngIT, Surefire2190JUnit4IT and
Surefire1993JpmsProvidingModulesIT green; fixture logs confirm maven-jar-plugin:3.5.1:jar executed.

(cherry picked from commit 6e80c75)


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

The windows-latest jdk-11 CI cell fails for every PR since Maven
3.10.0-rc-1 became the IT baseline: its super-POM pins maven-jar-plugin
3.5.0, whose plexus-archiver 4.10.4 throws an NPE
(JarToolModularJarArchiver.fixLastModifiedTimeZipEntries) when
packaging modular JARs on Windows with JDK < 14 (no 'jar --date'; POSIX
attribute view is null on Windows). Details and validation:
apache/maven-jar-plugin#555

maven-jar-plugin 3.5.1 (released 2026-07-22) ships plexus-archiver
4.12.0 with the fix. Pin 3.5.1 explicitly in the four affected modular
fixtures so they stop depending on the super-POM's jar-plugin version.

Verified locally under Maven 3.10.0-rc-1: Surefire1733JUnit4IT,
Surefire1733TestngIT, Surefire2190JUnit4IT and
Surefire1993JpmsProvidingModulesIT green; fixture logs confirm
maven-jar-plugin:3.5.1:jar executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 6e80c75)

@ascheman ascheman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same approach as the merged #3398 pin, extended to the modular-JAR IT fixtures that carry their own POMs (so they didn't inherit the pin). Correct fix for the plexus-archiver 4.10.4 NPE (jar#555) on Windows JDK<14. LGTM — thanks @slawekjaranowski. (Approving on the logic; the windows-latest jdk-11 cell is the one to watch as CI finishes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants