NUTCH-3197 Yetus: fix real precommit defects (shell, Docker, shelldocs) - #958
Open
lewismc wants to merge 2 commits into
Open
NUTCH-3197 Yetus: fix real precommit defects (shell, Docker, shelldocs)#958lewismc wants to merge 2 commits into
lewismc wants to merge 2 commits into
Conversation
…ocs) Child B of the Yetus master precommit initiative (follows NUTCH-3196). Fix shellcheck errors in bin/crawl and bin/nutch, add shelldocs annotations, restructure docker/Dockerfile for hadolint, exclude parse-js test sample from jshint, and waive DL3018 apk pinning via .hadolint.yaml.
…tion refactor Replace legacy backticks with $() on the cygpath assignment moved into the for-loop by the SC2144 fix so Yetus patch mode no longer reports a new shellcheck note on PR 956.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for NUTCH-3197
Follow-up to NUTCH-3196 (Child A: Yetus false-positive baselines). This is Child B of the Yetus master precommit initiative: fix real defects the gate correctly reported, without taking on historical style debt (Child C) or shellcheck warnings/notes (Child D).
Fork:
lewismc/nutch→apache/nutch(replaces incorrectly opened #956 from upstream branch).Summary
src/bin/crawlandsrc/bin/nutch(SC2071, SC2144, SC2242, SC2145) with behavior-preserving edits$(...)instead of backticks)@audience/@stabilityshelldocs annotations to five helper functions insrc/bin/crawldocker/Dockerfilefor hadolint (combined RUNs, quoting); waive DL3018 via.hadolint.yamlsrc/plugin/parse-js/sample/from jshint via.yetus/excludes.txt(test fixture, not production JS)Product codespell typos are in a linked follow-up PR from the same fork.
Out of scope (sibling issues)
@author, markdownlint → Child C (NUTCH-3198)NUTCH-3197-codespellTest plan
ant clean runtime testshellcheck -S error src/bin/crawl src/bin/nutch— no errors