Skip to content

drivers/pci: enable upstream bridge forwarding - #19948

Open
raiden00pl wants to merge 2 commits into
apache:masterfrom
raiden00pl:nuttx-intel64-pci-fix
Open

drivers/pci: enable upstream bridge forwarding#19948
raiden00pl wants to merge 2 commits into
apache:masterfrom
raiden00pl:nuttx-intel64-pci-fix

Conversation

@raiden00pl

Copy link
Copy Markdown
Member

Summary

PCI endpoints cannot perform memory transactions when a bridge in their hierarchy has memory forwarding or bus mastering disabled. Firmware may leave these bits clear when handing a device over after PXE boot.

Enable both bits on every parent bridge before enabling the endpoint.

Impact

fix PCI issues on intel64 hw after boot with PXE

Testing

Intel NUC with I226 NIC. After PXE boot over I226, without this changes - card is dead

PCI endpoints cannot perform memory transactions when a bridge in
their hierarchy has memory forwarding or bus mastering disabled.
Firmware may leave these bits clear when handing a device over
after PXE boot.

Enable both bits on every parent bridge before enabling the
endpoint.

Signed-off-by: raiden00pl <raiden00@railab.me>
Assisted-by: Claude Code
@raiden00pl
raiden00pl requested a review from btashton as a code owner August 24, 2026 10:57
@github-actions github-actions Bot added Size: S The size of the change in this PR is small Area: PCI labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@xiaoxiang781216

Copy link
Copy Markdown
Contributor

@raiden00pl please fix:

../nuttx/tools/checkpatch.sh -c -u -m -g  fae893d4115e43fcf530243b391f7708cc71a6af..HEAD
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:292:9: error: Bad right brace alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:513:2: error: Bad left brace alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:514:4: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:515:4: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:516:6: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:518:4: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:519:6: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:521:4: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:522:6: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:523:2: error: Bad right brace alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1142:6: error: Bad left brace alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1143:8: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1144:10: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1157:8: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1181:8: error: Bad alignment
Error: /home/runner/work/nuttx/nuttx/nuttx/drivers/pci/pci.c:1188:6: error: Bad right brace alignment

drivers/pci/pci.c: fix nxstyle issues

Signed-off-by: raiden00pl <raiden00@railab.me>
@github-actions github-actions Bot added Size: M The size of the change in this PR is medium and removed Size: S The size of the change in this PR is small labels Aug 24, 2026
@simbit18

Copy link
Copy Markdown
Contributor

@raiden00pl @xiaoxiang781216 after all the jobs have completed successfully

to solve this (job MSYS2)

  error: failed retrieving file 'libarchive-3.8.7-1-x86_64.pkg.tar.zst.sig' from ftp2.osuosl.org : Operation too slow. Less than 1 bytes/sec transferred the last 10 seconds
  warning: failed to retrieve some files
  error: failed to commit transaction (unexpected error)
  Errors occurred, no packages were upgraded.
  Error: Error: The process 'C:\Windows\system32\cmd.exe' failed with exit code 1

You need to Re-run failed jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: PCI Size: M The size of the change in this PR is medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants