Skip to content

Fix working of PURGE_VIEW_METADATA_ON_DROP#4730

Open
ayushtkn wants to merge 1 commit into
apache:mainfrom
ayushtkn:4727
Open

Fix working of PURGE_VIEW_METADATA_ON_DROP#4730
ayushtkn wants to merge 1 commit into
apache:mainfrom
ayushtkn:4727

Conversation

@ayushtkn

Copy link
Copy Markdown
Member

Fixes: #4727

Checklist

  • 🛡️ Don't disclose security issues! (contact security@apache.org)
  • 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
  • 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
  • 💡 Added comments for complex logic
  • 🧾 Updated CHANGELOG.md (if needed)
  • 📚 Updated documentation in site/content/in-dev/unreleased (if needed)

Copilot AI review requested due to automatic review settings June 12, 2026 14:47
@github-project-automation github-project-automation Bot moved this to PRs In Progress in Basic Kanban Board Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds purge-on-drop behavior for Iceberg views by passing view storage/location metadata into the cleanup task context, and verifies it via a new catalog test.

Changes:

  • Enable PURGE_VIEW_METADATA_ON_DROP in the Iceberg catalog test setup.
  • Update IcebergCatalog.dropView to collect view metadata + storage properties and pass them into dropTableLike for cleanup task creation.
  • Add a new test asserting a cleanup task is created and includes STORAGE_LOCATION for dropped views.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java Builds and forwards purge cleanup task context for dropped views (including storage/location metadata).
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractIcebergCatalogTest.java Enables the feature flag and adds coverage for drop-view-with-purge creating a cleanup task with storage location.

@ayushtkn ayushtkn force-pushed the 4727 branch 2 times, most recently from 481111f to 8bb69e4 Compare June 12, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable PURGE_VIEW_METADATA_ON_DROP, but not work

2 participants