[Fix][E2E] Stabilize engine failover test and rebalance connector shards#10949
Open
DanielLeens wants to merge 3 commits into
Open
[Fix][E2E] Stabilize engine failover test and rebalance connector shards#10949DanielLeens wants to merge 3 commits into
DanielLeens wants to merge 3 commits into
Conversation
… cleanup - backend.yml: add first-position removal patterns for connector-iceberg-e2e and connector-hbase-e2e so they are correctly stripped even when sorted first in the shard module list (previous //,module/ pattern silently missed first-position modules that have no leading comma) - KafkaIT.java: replace hardcoded jobId "18696753645413" in testRestoreKafkaToKafkaExactlyOnceOnStreaming with dynamic nanoTime value, consistent with how topic/group names are already dynamized - KafkaIT.java: track dynamically-created topics in a CopyOnWriteArrayList and delete them in tearDown() to prevent Kafka broker metadata bloat from accumulated retention.ms=-1 topics across CI runs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DanielLeens
force-pushed
the
david_fix_pr10925_ci_local
branch
from
065b2b3 to
5202424
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR extracts the remaining actionable CI fixes from the previous CI follow-up line without mixing them back into the DB2 work.
It addresses two concrete failures observed from the split CI PR line:
engine-v2-it (11)could fail inClusterFailureNoRestoreITbecause the batch job sometimes finished before the test actually shut down the worker.all-connectors-it-2 (11)could lose the hosted runner heartbeat because the shard was too heavy, especially whenconnector-iceberg-e2eandconnector-hbase-e2eran together with the rest of part-2.What is changed
ClusterFailureNoRestoreITby:RUNNINGconnector-iceberg-e2eandconnector-hbase-e2efromall-connectors-it-2all-connectors-it-8job for those two heavier suitesValidation
Executed in the local checkout used for this PR:
./mvnw spotless:apply -nsu -Dmaven.gitcommitid.skip=true -T 3Cgit diff --check -- .github/workflows/backend.yml seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFailureNoRestoreIT.javaall-connectors-it-2::connector-assert-e2e,:connector-file-cos-e2e,:connector-rabbitmq-e2e,:connector-easysearch-e2e,:connector-qdrant-e2e,:connector-aerospike-e2eall-connectors-it-8::connector-iceberg-e2e,:connector-hbase-e2eNot fully revalidated in this run
I also attempted a focused local runtime validation for
ClusterFailureNoRestoreIT, but the module is currently blocked by an unrelated upstream compile issue inLocalModeIT(SeaTunnelClient#getHealthMetrics(String)is missing from the current API surface in this branch line). That issue is outside the scope of this PR, so this PR keeps the fix focused on the two current actionable CI failures only.