Skip to content

[Improve][Connector-V2] Enhance JDBC chunk splitter logging #10950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhangshenghang wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Improve][Connector-V2] Enhance JDBC chunk splitter logging #10950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...bc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/ChunkSplitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ protected PreparedStatement createPreparedStatement(String sql) throws SQLExcept
if (connection.getAutoCommit() != autoCommit) {
connection.setAutoCommit(autoCommit);
}
log.debug("Prepared statement: {}", sql);
log.info("Prepared statement: {}", sql);
return jdbcDialect.creatPreparedStatement(connection, sql, fetchSize);
}

Expand Down
15 changes: 15 additions & 0 deletions ...main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/DynamicChunkSplitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,16 +903,31 @@ private static void prepareDynamicSplitStatement(
statement.setObject(i + 1, splitEnd[i]);
statement.setObject(i + 1 + splitKeyNumbers, splitEnd[i]);
}
log.info(
"Dynamic split (first) - params: [{}={}, {}={}]",
1,
splitEnd[0],
2,
splitEnd[0]);
} else if (isLastSplit) {
for (int i = 0; i < splitKeyNumbers; i++) {
statement.setObject(i + 1, splitStart[i]);
}
log.info("Dynamic split (last) - params: [{}={}]", 1, splitStart[0]);
} else {
for (int i = 0; i < splitKeyNumbers; i++) {
statement.setObject(i + 1, splitStart[i]);
statement.setObject(i + 1 + splitKeyNumbers, splitEnd[i]);
statement.setObject(i + 1 + 2 * splitKeyNumbers, splitEnd[i]);
}
log.info(
"Dynamic split (middle) - params: [{}={}, {}={}, {}={}]",
1,
splitStart[0],
2,
splitEnd[0],
3,
splitEnd[0]);
}
}

Expand Down
7 changes: 7 additions & 0 deletions ...c/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/source/FixedChunkSplitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ private PreparedStatement createStringColumnSplitStatement(JdbcSourceSplit split
throws SQLException {
PreparedStatement statement = createPreparedStatement(split.getSplitQuery());
statement.setInt(1, (Integer) split.getSplitStart());
log.info("String column split - param[1]: {}", split.getSplitStart());
return statement;
}

Expand Down Expand Up @@ -410,6 +411,12 @@ private Collection<JdbcSourceSplit> createNumberColumnSplits(
jdbcNumericBetweenParametersProvider.getParameterValues();
List<JdbcSourceSplit> splits = new ArrayList<>(table.getPartitionNumber());
for (int i = 0; i < parameterValues.length; i++) {
log.info(
"Number column split - params: [{}={}, {}={}]",
1,
parameterValues[i][0],
2,
parameterValues[i][1]);
JdbcSourceSplit split =
new JdbcSourceSplit(
table.getTablePath(),
Expand Down
Loading