Skip to content

[Fix][Connector-V2] Fix Arrow memory leak by correcting close order in ArrowToSeatunnelRowReader #10958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidzollo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Fix][Connector-V2] Fix Arrow memory leak by correcting close order in ArrowToSeatunnelRowReader #10958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .../seatunnel/connectors/seatunnel/common/source/arrow/reader/ArrowToSeatunnelRowReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,15 +320,17 @@ private Function<Object, Object> genericsConvert(SeaTunnelDataType dataType) {
@Override
public void close() {
try {
if (root != null) {
root.close();
// ArrowStreamReader must be closed before RootAllocator.
// ArrowStreamReader internally closes VectorSchemaRoot and releases all Arrow
// buffer allocations back to the allocator. If the allocator is closed first,
// it detects unreleased memory and throws IllegalStateException ("Memory was
// leaked by query"), which is the root cause of issue #9863.
if (arrowStreamReader != null) {
arrowStreamReader.close();
}
if (rootAllocator != null) {
rootAllocator.close();
}
if (arrowStreamReader != null) {
arrowStreamReader.close();
}
} catch (IOException e) {
throw new RuntimeException("failed to close arrow stream reader.", e);
}
Expand Down
Loading