Skip to content

[#2799] enh: warn if realm authentication fails#2798

Merged
lprimak merged 2 commits into
apache:mainfrom
lprimak:multi-realm-failure-warn
Jun 19, 2026
Merged

[#2799] enh: warn if realm authentication fails#2798
lprimak merged 2 commits into
apache:mainfrom
lprimak:multi-realm-failure-warn

Conversation

@lprimak

@lprimak lprimak commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Enhancement.

Warn if realm authentication fails due to system exceptions in m in multi-realm environment, and send an event

  • Added EventBus reference to AbstractAuthenticator and made it EventBusAware

  • Same for AuthenticationStrategy

  • Added AuthenticationExceptionEvent event that is published to EventBus

  • Added isWarnIfAuthenticatorFailed flag to AtLeastOneSuccessfulStrategy

  • Warn if authentication fails due to system exception in multi-realm scenario, don't swallow the exception

  • Send the AuthenticationExceptionEvent to event bus if that happens

  • A chore to update Payara settings (will be rebased-and-merged so a separate commit)

fixes #2799

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 3.0.0 milestone Jun 18, 2026
@github-actions github-actions Bot added java Pull requests that update Java code tests labels Jun 18, 2026
@lprimak lprimak changed the title enh: warn if realm authentication fails due to system exceptions in m… [#2799] enh: warn if realm authentication fails due to system exceptions in m… Jun 18, 2026
@lprimak lprimak changed the title [#2799] enh: warn if realm authentication fails due to system exceptions in m… [#2799] enh: warn if realm authentication fails Jun 18, 2026
@lprimak lprimak self-assigned this Jun 18, 2026

@steinarb steinarb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

(and so I learned about the existence of EventBus)

lprimak added 2 commits June 18, 2026 04:20
…iguration, and make dependabot see payara for updates
@lprimak lprimak force-pushed the multi-realm-failure-warn branch from c74a18b to e6aa5d0 Compare June 18, 2026 09:22
@lprimak lprimak merged commit 8856874 into apache:main Jun 19, 2026
16 checks passed
@lprimak lprimak deleted the multi-realm-failure-warn branch June 19, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

groovy java Pull requests that update Java code tests xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Multi-realm system failures are not logged but swallowed

3 participants