[ISSUE-4315][Bug] Fix multiline dynamic properties parsing#4359
Open
hutiefang76 wants to merge 1 commit into
Open
[ISSUE-4315][Bug] Fix multiline dynamic properties parsing#4359hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Close #4315.
This fixes dynamic properties parsing when a long option value is split across multiple lines in the textarea, for example
yarn.ship-files. Lines that do not start with-Dare now treated as continuations of the previous dynamic property before the existing parser runs.The existing single-line and quoted value cases continue to use the same parsing path.
Verification
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl streampark-common -Dtest=org.apache.streampark.common.util.PropertiesUtilsTestCase testJAVA_HOME=$(/usr/libexec/java_home -v 17) ./mvnw -pl streampark-common testgit diff --checkNote: the local default JDK is newer than the Scala 2.12 compiler bridge supports cleanly, so the verification commands above explicitly use JDK 17.