[ISSUE-4072][Bug] Use SSL when checking alert email#4363
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changed
This fixes the alert email connection check for SSL SMTP settings.
The actual email sending path uses SSL-on-connect when
SenderEmail.sslis enabled, butSettingServiceImpl.checkEmailwas enabling STARTTLS instead. That makes the check fail for SSL SMTP servers such as the case reported in #4072.This patch extracts the JavaMail property building and makes
checkEmailsetmail.smtp.ssl.enable=truewhen SSL is selected. Plain SMTP keeps the existing behavior.Tests
Also checked:
I used OpenAI Codex to help inspect the issue and prepare the patch, then reviewed the diff and ran the tests above locally.