[ISSUE-4157][Bug] Parse vendor suffixed Flink versions#4364
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request
Issue Number: close #4157
This pull request updates
FlinkVersion.checkVersionto parse the numeric prefix of each version segment. This keeps normal Apache Flink versions unchanged while allowing vendor-suffixed patch versions such as1.19.1-amzn-1to be checked without throwingNumberFormatException.Brief change log
FlinkVersionbefore matching supported Flink versions.checkVersion()andcheckVersion(sinceVersion)paths.Verifying this change
This change added tests and can be verified as follows:
FlinkVersionTestto verify1.19.1-amzn-1is accepted and unsupported vendor-suffixed versions are rejected without throwing.Result:
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0.Does this pull request potentially affect one of the following parts