Skip to content

TEZ-4750: Relax yarn nodemanager health checker in tez_run_example.sh - #533

Open
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4750
Open

TEZ-4750: Relax yarn nodemanager health checker in tez_run_example.sh#533
abstractdog wants to merge 1 commit into
apache:masterfrom
abstractdog:TEZ-4750

Conversation

@abstractdog

Copy link
Copy Markdown
Contributor

No description provided.

@abstractdog
abstractdog requested a review from ayushtkn August 16, 2026 11:46
@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 3m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 4m 47s master passed
+1 💚 compile 4m 4s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 42s the patch passed
+1 💚 codespell 1m 37s No new issues.
+1 💚 compile 4m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
_ Other Tests _
-1 ❌ unit 71m 40s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
95m 51s
Reason Tests
Failed junit tests tez.test.TestAMRecovery
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/1/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense codespell detsecrets shellcheck shelldocs
uname Linux 5fd2057bc787 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / d348bf1
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/1/testReport/
Max. process+thread count 1515 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/1/console
versions git=2.43.0 maven=3.9.15 codespell=2.4.1 shellcheck=0.11.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

</property>
<property>
<name>yarn.nodemanager.disk-health-checker.max-disk-utilization-per-disk-percentage</name>
<value>99.0</value>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the value is 90 as per, any particular reason to chase extra 9%
https://hadoop.apache.org/docs/r3.5.0/hadoop-yarn/hadoop-yarn-common/yarn-default.xml

@abstractdog abstractdog Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's because I bump into it all the time: I believe other developers like me are also fine with spending most of their time with 90+ percent full disk without bumping into issues like this, 99% is the upper limit I consider serious (at that level, my laptop also starts to warn about disk space)

(bumping into it all the time, I mean: TEZ-4366, TEZ-4123)

@Aggarwal-Raghav Aggarwal-Raghav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rerun the CI as there are UT failures .

@abstractdog

Copy link
Copy Markdown
Contributor Author

Please rerun the CI as there are UT failures .

sure, also created TEZ-4751 about TestAMRecovery

@tez-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 12s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 4m 48s master passed
+1 💚 compile 4m 1s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 codespell 1m 36s No new issues.
+1 💚 compile 4m 2s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
_ Other Tests _
-1 ❌ unit 76m 35s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
97m 17s
Reason Tests
Failed junit tests tez.dag.app.TestSpeculation
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/2/artifact/out/Dockerfile
Optional Tests dupname compile unit asflicense codespell detsecrets shellcheck shelldocs
uname Linux 4a501f5513a7 5.15.0-186-generic #196-Ubuntu SMP Sat Jun 20 16:09:34 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality tez-personality.sh
git revision master / 64e79ee
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/2/testReport/
Max. process+thread count 1492 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-533/2/console
versions git=2.43.0 maven=3.9.15 codespell=2.4.1 shellcheck=0.11.0
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

@Aggarwal-Raghav

Copy link
Copy Markdown
Contributor

tez.dag.app.TestSpeculation is flaky as well, it failed for my PR also, yesterday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants