Handle OpenSSL without dynamic ENGINE#13264
Open
bneradt wants to merge 1 commit into
Open
Conversation
Some OpenSSL builds expose the async APIs ATS can use while disabling the legacy ENGINE interface. On those platforms, such as RHEL 10, the test-only async_engine plugin fails to compile even though runtime TLS async support can still be built without it. This adds a CMake compile check for dynamic ENGINE availability and uses it to gate the test plugin. The TLS engine AuTest now skips when the test plugin was not built, while ENGINE-capable builds continue to build and run the test.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves build/test portability for OpenSSL configurations that provide async TLS APIs but disable the legacy dynamic ENGINE interface (e.g., some distro builds). It prevents the test-only async_engine AuTest plugin from being built when dynamic ENGINE isn’t available, and updates the TLS engine gold test to skip cleanly in that scenario.
Changes:
- Add a CMake compile probe (
HAVE_OPENSSL_DYNAMIC_ENGINE) to detect OpenSSL dynamic ENGINE availability. - Gate building/linking the
async_engineAuTest plugin on bothTS_USE_TLS_ASYNCandHAVE_OPENSSL_DYNAMIC_ENGINE. - Update the
tls_enginegold test to skip unless theasync_engine.sotest plugin exists, and reuse the computed plugin path for the copy step.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CMakeLists.txt |
Adds a compile-time probe for OpenSSL dynamic ENGINE support (HAVE_OPENSSL_DYNAMIC_ENGINE). |
tests/tools/plugins/CMakeLists.txt |
Builds the async_engine AuTest plugin only when async TLS is enabled and dynamic ENGINE is available. |
tests/gold_tests/tls/tls_engine.test.py |
Skips the test when async_engine.so wasn’t built and avoids repeating the plugin path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OpenSSL builds expose the async APIs ATS can use while disabling the legacy ENGINE interface. On those platforms, such as RHEL 10, the test-only async_engine plugin fails to compile even though runtime TLS async support can still be built without it.
This adds a CMake compile check for dynamic ENGINE availability and uses it to gate the test plugin. The TLS engine AuTest now skips when the test plugin was not built, while ENGINE-capable builds continue to build and run the test.