Update rhai imports#9529
Closed
Abendrill wants to merge 4 commits into
Closed
Conversation
Apply the changeset style guide to every .changesets/*.md in advance of the v2.15.0 prep, with the upstream style guide as primary authority (https://github.com/apollographql/docs-rewrite/blob/main/apps/docs-renderer/ai/style-guide/changesets.md) and shipped CHANGELOG.md entries as the shape reference. Highlights: - Drop `fix:` / `Fix X` titles in favor of outcome-led verbs ("Evaluate", "Scope", "Identify", "Record", "Resolve"). - Reframe "no longer X" negatives as positives ("Retry reloads ...", "Drop duplicate ... notifications ..."). - Add the missing `([PR #N](...))` (or Issue) refs to titles where they were absent, matching the convention in `.changesets/README.md` and every shipped CHANGELOG entry. - Body reorders to lead with the user-visible outcome rather than internal mechanism (sigv4 context model, rhai retry loop internals, is_primary FIRST_EVENT_CONTEXT_KEY reference, apply_root_selection_set map-op detail). Drop internal-only macro reference from the coprocessor timeout entry (belongs in PR, not the changelog entry). Already-good changesets (connection.acquire.duration, file-upload operation_body_timeout, subgraph/connector response size limits, subscription dedup ignore_auth_context, doc updates, max_lifetime) were left untouched.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@Abendrill: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
✅ AI Style Review — No Issues FoundThe pull request does not have any style issues. Duration: 2570ms
|
Author
|
My issue was fixed by rhaiscript/rhai#1099, so I'll close this. If somebody else want to drive this, feel free to adopt and reopen this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9528
Updates imports of certain types from
rhaito be compatible withrhai@1.25.0.The current import path was removed in
rhai@1.25.0.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩