Repository navigation
fix(utils): clean up interrupted mouse gestures - #285
Open
yinx65588-boop wants to merge 4 commits into
Open
yinx65588-boop wants to merge 4 commits into
yinx65588-boop wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroying an
interactionHandleraction between mousedown and mouseup leaves its window listeners installed. Moving or releasing the mouse can then start a drag, update a removed component, or invoke its click/up callbacks. An active drag also never receivescancel, even though the rectangle and dashboard placement handlers already implement it to release interaction state.Keep a cleanup function for the current gesture, remove window listeners on destruction or replacement, and cancel an interrupted drag once. Normal mouseup clears the active handler before calling
up, so anupcallback that destroys the action does not cancel a completed drag.The root type-check script also named a nonexistent
@embedding-atlas/embedding-atlasworkspace.npm pkg get name --workspace=@embedding-atlas/embedding-atlasreproducesNo workspaces foundon the baseline; the package manifest names itembedding-atlas. Correct that one reference so the required checks can actually run.Validation on Windows / Node 24:
EventTarget: the original three failures were reproduced on upstreamef64656, and a further cancellation/destruction regression failed on the first revision before being fixed. Coverage includes destruction before/after the drag threshold, replacement, normal release/clicks, repeated destruction, and destruction fromup,cancel, drag initialization or blur. Reentrant callbacks that start a replacement gesture are also covered.npm run build -w @embedding-atlas/utilspasses.npm test -w @embedding-atlas/utils: 134 tests pass.npm test -w @embedding-atlas/viewer: 144 tests pass.cancelcallback against the first and latest revisions.git diff --check, and utils packaging/publint pass. Independent Codex source review reports no actionable P0–P2 findings on the latest commit.Linux CI validation passes all five jobs on a proof branch whose only difference from PR head
09581170c09f72ea7830cb5b8f05d6fc778c1ab1is the workflow file. Application/WASM builds and type checks pass, along with 332 JS tests, 234 Python tests (21 skipped), 100 Rust tests, formatting and Clippy. Python wheel install/import/CLI smoke tests also pass on 3.11, 3.12, 3.13 and 3.14. It omits documentation site generation and the expensive cold-cache inference used to generate demo datasets; the earlier unmodified CI run was cancelled during that unrelated step. Publishing jobs are omitted.Upstream pull-request CI is waiting for maintainer approval to run; fork validation does not satisfy its required check.
AI assistance was used for the change and validation.