Repository navigation
fix(widget): support format="predicate" in selection() - #288
Merged
Merged
Conversation
donghaoren
approved these changes
Oct 27, 2026
donghaoren
enabled auto-merge (squash)
October 27, 2026 00:11
kwy404
added a commit
to kwy404/kwy404
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
EmbeddingAtlasWidget.selection(packages/backend/embedding_atlas/widget.py) documents'dataframe','arrow'and'predicate'as formats, and its error message lists all three, but only'dataframe'and'arrow'are handled. Asking for the predicate always raises:Fix: return
self._predicateforformat="predicate", before running the query. It is the SQL predicate the frontend syncs for the current selection, orNonewhen nothing is selected, the same value the Streamlit component returns aspredicate.Test: added
test_selection_as_predicatetopackages/backend/tests/test_widget.py. It checks that the predicate isNonewithout a selection and is returned as is once set. Before the fix it fails with theValueErrorabove, after the fixpytest tests/test_widget.pypasses, andruff format --checkis clean.