Repository navigation
feat: select search results alongside filters - #291
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
Member
|
Could you add screenshots and explain the interactions in the description? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286
Adds an explicit Select results action to the search result panel. It adds the returned result IDs as a cross-filter clause, preserving existing brush/filter clauses; a later search selection replaces only the prior search-result clause. Empty results do nothing, and duplicate IDs are deduplicated. The action selects the returned results (the existing search limit is 500); users can reset filters first to select all items, as discussed in #286.
Interaction
Screenshot
No screenshot is attached. In an isolated checkout, I generated the density-clustering and UMAP WASM bindings from the project's Rust source. This session does not expose a native browser-control pipe or browser host, so I could not render and capture a genuine interaction screenshot. I have not substituted a mock screenshot.
Previous task validation:
npm run test -w @embedding-atlas/viewer— 147 tests passed. This continuation did not rerun tests; viewer Svelte check and full viewer build remain unverified here.