Skip to content

feat: select search results alongside filters - #291

Open
dajiaohuang wants to merge 2 commits into
apple:mainfrom
dajiaohuang:fix/issue-286-select-search-results
Open

dajiaohuang wants to merge 2 commits into
apple:mainfrom
dajiaohuang:fix/issue-286-select-search-results

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 27, 2026 •

Copy link
Copy Markdown

Closes #286

Adds an explicit Select results action to the search result panel. It adds the returned result IDs as a cross-filter clause, preserving existing brush/filter clauses; a later search selection replaces only the prior search-result clause. Empty results do nothing, and duplicate IDs are deduplicated. The action selects the returned results (the existing search limit is 500); users can reset filters first to select all items, as discussed in #286.

Interaction

  1. Open search and enter a query; matching results appear in the search result panel.
  2. Choose Select results to add those returned IDs to the current cross-filter selection. Existing brush and other filter clauses remain active.
  3. Running a later query and choosing Select results replaces only the previous search-result selection. An empty result set leaves the current selection unchanged. To select all items, reset filters before searching/selecting.

Screenshot

No screenshot is attached. In an isolated checkout, I generated the density-clustering and UMAP WASM bindings from the project's Rust source. This session does not expose a native browser-control pipe or browser host, so I could not render and capture a genuine interaction screenshot. I have not substituted a mock screenshot.

Previous task validation: npm run test -w @embedding-atlas/viewer — 147 tests passed. This continuation did not rerun tests; viewer Svelte check and full viewer build remain unverified here.

@domoritz

Copy link
Copy Markdown
Member

Could you add screenshots and explain the interactions in the description?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create selection from full text search / nearest neighbors

2 participants