Repository navigation
fix(viewer): preserve projection data fields when merging config.embedding overrides - #304
Merged
donghaoren merged 1 commit intoNov 16, 2026
Conversation
…ts embedding overrides
donghaoren
approved these changes
Nov 16, 2026
donghaoren
enabled auto-merge (squash)
November 16, 2026 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.embedding.dataonto the default projectiondataobject instead of shallow-replacingspec.dataindefaultCharts()(packages/viewer/src/charts/default_charts.ts).DefaultChartsConfig["embedding"]so partialdataoverrides (e.g.{ data: { category: "label" } }) are accepted without re-specifyingxandy.config.embedding != nullso a runtimenullvalue does not crash when reading.data.packages/viewer/test/default_charts.test.ts.Verification
npx prettier -c packages/viewer/src/charts/default_charts.ts packages/viewer/test/default_charts.test.ts: passednpm --workspace packages/viewer test: 12 test files passed, 146/146 tests passed