Skip to content

Fix XXH3_128 digestLength #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattmook wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix XXH3_128 digestLength #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cryptohash/src/commonMain/kotlin/com/appmattus/crypto/internal/core/xxh3/XXH3_128.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ internal class XXH3_128(val parameters: Algorithm.XXH3_128) : AbstractDigest<XXH
}

override val digestLength: Int
get() = 8
get() = 16

override fun reset() {
when (parameters) {
Expand Down
10 changes: 10 additions & 0 deletions cryptohash/src/commonTest/kotlin/com/appmattus/crypto/internal/xxh3/XXH3_128Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.appmattus.crypto.internal.CoreDigest
import com.appmattus.crypto.internal.core.sphlib.testKat
import com.appmattus.crypto.internal.core.xxh3.XXH3_SECRET_SIZE_MIN
import kotlin.test.Test
import kotlin.test.assertEquals

@Suppress("ClassName")
class XXH3_128Test {
Expand All @@ -31,6 +32,15 @@ class XXH3_128Test {
val nResult: String
)

@Test
fun digestLength() {
val digest = CoreDigest.create(Algorithm.XXH3_128())

val result = digest.digest(buffer(0))

assertEquals(digest.digestLength, result.size)
}

@Test
fun xxh3_128bits_seeded() {
listOf(
Expand Down
Loading