Skip to content

fix(APP-983): Implement scrolling into the proposal creation eligibility section and remove the "No description" fallback text (APP-947 4/4)#1219

Merged
milosh86 merged 30 commits into
mainfrom
app-983-fix-scroll-to-eligibility-section-and-no-description
Jul 15, 2026
Merged

fix(APP-983): Implement scrolling into the proposal creation eligibility section and remove the "No description" fallback text (APP-947 4/4)#1219
milosh86 merged 30 commits into
mainfrom
app-983-fix-scroll-to-eligibility-section-and-no-description

Conversation

@milosh86

@milosh86 milosh86 commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes scrolling into the proposal creation eligibility section on the process settings page when navigating from a "not eligible" link with the #proposal-creation-eligibility hash. Also removes the "No description" fallback text on process list items when a process has no description, and prevents the proposal creation simulation from refetching on window focus (which caused a UI jump).

Type of Change

  • Major: Breaking change (change that would cause existing functionality to not work as expected)
  • Minor: Feature (non-breaking change which adds new functionality)
  • Patch: Enhancement (non-breaking change to an existing feature)
  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisfied
  • Confirmed there are no new warnings on automated tests
  • Merged and published any dependent changes in downstream modules
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • (For User Stories only) Tested in a preview or locally that all Acceptance Criteria are satisfied
  • Confirmed that changes follow the code style guidelines of this project

tyhonchik and others added 29 commits July 7, 2026 21:52
@tyhonchik
chore: monorepo tooling: pnpm workspace, turbo scripts, CI regroup, docs
425c61d 
Companion to the pure-rename commit; together they convert the repo
into a pnpm monorepo with the app living in apps/app (@aragon/app,
version and package name unchanged).

- pnpm-workspace.yaml: packages [apps/*, packages/*]; lockfile regenerated
- new root package.json (no version): tooling deps (turbo, biome,
  ultracite, husky, lint-staged, changesets, vercel) and proxy scripts
  via `turbo run` / `pnpm --filter @aragon/app`, so root `pnpm
  type-check|lint|test|e2e|setup` keep working and CI needs no rewiring
- turbo.json: dev/build/lint:check/test:coverage tasks added
- workflows regrouped per app: app-release-v2 -> app-release-start,
  release-pr-* -> app-release-pr-*, hotfix-start -> app-hotfix-start,
  slot-docs -> app-slot-docs; legacy app-release.yml deleted
  (superseded by the release-PR flow)
- CI paths: 1Password secrets to apps/app/.env, playwright/synpress
  steps get working-directory, release flows read version/CHANGELOG
  from apps/app, slot-docs filters prefixed
- biome/.changeset/.gitignore globs point at apps/app; jest drops
  agent-hook ignore patterns; guardrails scripts stay at the root
- rule-skill globs prefixed with apps/app/ (matched repo-root-relative)
- AGENTS.md monorepo section, new root README.md, MIGRATION.md with a
  verified branch-migration recipe (incl. post-rebase leftovers step:
  git silently leaves new files in new subdirs at old paths)
- .git-blame-ignore-revs: the pure-rename commit
@milosh86
chore: Update return type of useSimulateProposalCreation to distingui…
db643bb 
…sh between simulation and request failure

Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
feat: disable process list items where user is not eligible
347a8a8 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: onClick type issue
3182af7 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: update text style and size
2edea33 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
chore: add changeset
e9a1db3 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
Merge branch 'chore/monorepo-skeleton' into app-978-update-usesimulat…
e223875 
…eproposalcreation-params-and-return-type
@milosh86
Merge branch 'app-978-update-usesimulateproposalcreation-params-and-r…
8902538 
…eturn-type' into app-979-add-simulation-to-processdatalistitem
@milosh86
chore: add changeset
d11d713 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
chore: derive aria-disabled from isDisabled flag
8c2874e 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: var typo
e7472c4 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
Merge branch 'main' into app-978-update-usesimulateproposalcreation-p…
485e68b 
…arams-and-return-type
@milosh86
Merge branch 'app-978-update-usesimulateproposalcreation-params-and-r…
d286402 
…eturn-type' into app-979-add-simulation-to-processdatalistitem
@milosh86
chore: remove #proposal-creation-eligibility ID
227e175 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: update eligibility presentation
97d28bc 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
feat: implement process sort by eligibility
ab8cb94 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: add useMemo to transaction building
4b54a43 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
chore: add changeset
657f4c9 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
Merge branch 'app-978-update-usesimulateproposalcreation-params-and-r…
bcdc45d 
…eturn-type' into app-979-add-simulation-to-processdatalistitem
@milosh86
Merge branch 'app-979-add-simulation-to-processdatalistitem' into app…
cc2d2b9 
…-982-manage-processes-order-and-selection-globally-from-select
@milosh86
refactor: simplify based on PR review
b29d127 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: cover corner case when dao is not loaded
2013f09 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
Merge branch 'app-978-update-usesimulateproposalcreation-params-and-r…
2d1739b 
…eturn-type' into app-979-add-simulation-to-processdatalistitem
@milosh86
Merge branch 'app-979-add-simulation-to-processdatalistitem' into app…
565259f 
…-982-manage-processes-order-and-selection-globally-from-select
@milosh86
feat: implement scrolling into proposal creation eligibility section …
e0cc7a9 
…if url hash exists

Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
refactor: don't render process description fallback if description no…
5f7ed63 
…t set

Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
refactor: don't refetch simulation on focus to prevent UI jump
debc1ff 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
fix: test should only check relevant flags
bb10987 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
chore: add changeset
6d3868a 
Signed-off-by: Milos Dzepina <milos@aragon.org>
@linear-code

linear-code Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

APP-983

APP-947

@milosh86 milosh86 changed the title fix(APP-983): Fix scrolling into the proposal creation eligibility section fix(APP-983): Fix scrolling into the proposal creation eligibility section (APP-947 4/4) Jul 10, 2026
@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@milosh86 milosh86 changed the base branch from main to app-982-manage-processes-order-and-selection-globally-from-select July 10, 2026 08:12
@milosh86 milosh86 changed the title fix(APP-983): Fix scrolling into the proposal creation eligibility section (APP-947 4/4) fix(APP-983): Implement scrolling into the proposal creation eligibility section and remove the "No description" fallback text (APP-947 4/4) Jul 10, 2026
@milosh86 milosh86 marked this pull request as ready for review July 10, 2026 08:14
@milosh86 milosh86 requested a review from a team as a code owner July 10, 2026 08:14
@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

E2E results (preview)

Smoke
Base URL https://app-next-cf3cmtrkh-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 79 passed, 1 skipped
HTML report View report
GitHub job ✅ completed

View run #4535

thekidnamedkd
thekidnamedkd reviewed Jul 10, 2026
View reviewed changes

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refetchOnWindowFocus: false on the query is a genuine UX fix — no one wants their selection screen flickering because they alt-tabbed to check their wallet.

The scroll-to-section completes what PR 2/4 started with the link. Happy with the hash check approach.

One note: the scroll effect only fires once on initial render with the hash. Works fine for the deep-link case since the user navigates fresh to the page with the hash. Just noting it in case we ever wanted re-scroll on same-page navigation.

@milosh86

milosh86 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Not sure I understand what the re-scroll case would be?

Whenever you open a page with this hash, it would scroll to the "proposal creation eligibility" section if it exists.

thekidnamedkd
thekidnamedkd previously approved these changes Jul 14, 2026
View reviewed changes

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify the re-scroll note: I meant the hypothetical where we're already on the process details page and something re-navigates to the same URL + hash — the component doesn't remount so the effect wouldn't re-fire. But since the only way into this anchor is the link in the select dialog (a different page), it's always a fresh mount and it just works. Purely a "if we ever add an in-page link" thing, no action needed. Nice wrap-up to the series, and the refetchOnWindowFocus fix is a genuine QoL win. LGTM 🚀

Base automatically changed from app-982-manage-processes-order-and-selection-globally-from-select to main July 14, 2026 15:11
@milosh86 milosh86 dismissed thekidnamedkd’s stale review July 14, 2026 15:11

The base branch was changed.

@thekidnamedkd thekidnamedkd self-requested a review July 15, 2026 08:58
thekidnamedkd
thekidnamedkd approved these changes Jul 15, 2026
View reviewed changes

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeee 👍

@milosh86 milosh86 merged commit 6477c04 into main Jul 15, 2026
19 checks passed
@milosh86 milosh86 deleted the app-983-fix-scroll-to-eligibility-section-and-no-description branch July 15, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes
@tyhonchik tyhonchik Awaiting requested review from tyhonchik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@milosh86 @thekidnamedkd @tyhonchik