Repository navigation
Conversation
The process of updating `__VERSION__` and producing `dist/bin/downgrade` has a bug, a pretty a bad one. By testing with the built file in `dist` rather than the original one in `src`, we can catch such bugs.
`m4` mangles some quoted expressions. I have no idea when or why or how to avoid it reliably. Since we're only replacing a single variable, `sed` is simpler.
This reverts commit cb15393 and brings back `--git`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(test): shellcheck
9560363
chore(test): test build file, not source
30c2bbc
The process of updating
__VERSION__and producingdist/bin/downgradehas a bug, a pretty a bad one. By testing with the built file in
distrather than the original one in
src, we can catch such bugs.chore(release): update VERSION with sed, not m4
5610a4e
m4mangles some quoted expressions. I have no idea when or why or howto avoid it reliably. Since we're only replacing a single variable,
sedis simpler.feat: add ability to downgrade aur package using git
6990fbd
This reverts commit cb15393 and brings
back
--git.