Skip to content

ci: run actionlint from mise, not a Docker action - #288

Merged
qw-in merged 2 commits into
mainfrom
quinn/fix-lint-workflows
Oct 29, 2026
Merged

qw-in merged 2 commits into
mainfrom
quinn/fix-lint-workflows

Conversation

@qw-in

@qw-in qw-in commented Oct 29, 2026

Copy link
Copy Markdown
Member

lint-workflows has been failing for a while. Attempt to resolve

qw-in and others added 2 commits October 29, 2026 09:35
The Docker container action made the workflow fail with startup_failure before any job ran, because container actions cannot start in this org's repos.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@arcjet-review arcjet-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arcjet Review — 🟢 Normal Risk

Decision: Approved

Rationale: This is a narrowly scoped CI installation change with no concrete correctness or security issue found. It preserves actionlint 1.7.12 and its arguments, retains read-only permissions and disabled checkout credentials, and pins the new action by commit SHA. Pinning the mise executable would further improve reproducibility.

Summary of Changes

Replaces the Docker-based actionlint invocation with installation through mise followed by a direct shell invocation. The zizmor check remains unchanged.

Escalation Triggers

  • CI/CD Pipeline: Changes tool installation and execution in .github/workflows/lint-workflows.yml.
  • Dependency Changes: Introduces jdx/mise-action and mise as CI tooling dependencies.

Review Steps

API Review

Relevancy Outcome
none ⏭️ Skipped

Data Flow Map

Relevancy Outcome
none ⏭️ Skipped

Dependency Audit

Relevancy Outcome
medium ⚠️ Concerns

Using an established installer is reasonable; explicitly pinning mise would improve reproducibility.

Docs Review

Relevancy Outcome
none ⏭️ Skipped

Historical ADR Review

Relevancy Outcome
none ⏭️ Skipped

Migration Safety

Relevancy Outcome
none ⏭️ Skipped

Security Review

Relevancy Outcome
medium ✅ Pass

No new secret exposure, unsafe input interpolation, or permission expansion identified.

Test Coverage

Relevancy Outcome
medium ✅ Pass

The existing workflow exercises installation and actionlint execution on workflow-changing PRs; no additional unit tests are needed.

Zero Data Retention

Relevancy Outcome
none ⏭️ Skipped

WorkOS Audit Logging

Relevancy Outcome
none ⏭️ Skipped

Notes

Static review only; workflow execution results were not available, so restoration of the previously failing check was not independently verified.

Review: e63d7fab | Model: openai/gpt-6-astra | Powered by Arcjet Review

Comment thread .github/workflows/lint-workflows.yml Resolved
@qw-in
qw-in enabled auto-merge October 29, 2026 16:43
@arcjet-review arcjet-review Bot added the ready Ready to merge label Oct 29, 2026
@qw-in
qw-in added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 498b28b Oct 29, 2026
35 of 63 checks passed
@qw-in
qw-in deleted the quinn/fix-lint-workflows branch October 29, 2026 16:55
@arcjet-review arcjet-review Bot removed the ready Ready to merge label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant