Repository navigation
fix: clear clippy's findings under -D warnings - #240
Open
robfischer1 wants to merge 1 commit into
Open
robfischer1 wants to merge 1 commit into
robfischer1 wants to merge 1 commit into
Conversation
`cargo clippy --workspace --all-targets -- -W clippy::all -D warnings` (Rust 1.97) fails on main with: - three useless `.into()` conversions of a String in func.rs and three redundant `&` in format! arguments (func.rs, imports.rs); - clippy::too_many_arguments inside wit-bindgen's generate! expansion in the records example: the export glue for modify-foo takes one argument per flattened field of foo, ten. examples/records/clippy.toml raises the threshold to 16, the canonical ABI's flat-parameter limit, rather than suppressing the lint. It also drops two `#[allow(dead_code)]` on Direction::Export and Func::export, both of which ExportGenerator uses, so they suppressed nothing. No generated output changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arcjet-rei
approved these changes
Oct 7, 2026
arcjet-rei
left a comment
arcjet-rei
left a comment
Contributor
There was a problem hiding this comment.
It's kind of embarrassing that clippy wasn't already part of our CI flow (we'll be adding it shortly after this lands). Thanks for putting this together.
As noted on #233, commits onto this repo must be signed, so once that's taken care of, I'll get this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The findings were:
.into()calls.&informat!.too_many_argumentsinside wit-bindgen's expansion in the records example.The last one is fixed by setting the records example's
clippy.tomlthreshold to 16, the canonical ABI's flat-parameter limit, instead of suppressing the lint. The PR also removes two stale#[allow(dead_code)].No generated output changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01K99bnsYaj3w4MMWSF5hTMu